pipecd icon indicating copy to clipboard operation
pipecd copied to clipboard

nodeSelector ?

Open m4dm4rtig4n opened this issue 3 years ago • 3 comments

Hello,

It's possible to add in helm chart deployment chart to add nodeSelector ?

Exemple : nodeSelector: kubernetes.io/hostname: k3smaster1

Thx

m4dm4rtig4n avatar Apr 27 '22 11:04 m4dm4rtig4n

@m4dm4rtig4n Hi, thank you for your issue.

Could you please tell me which Helm chart you want to specify nodeSelector? The helm chart of PipeCD (https://github.com/pipe-cd/pipecd/tree/master/manifests/pipecd) or Piped (https://github.com/pipe-cd/pipecd/tree/master/manifests/piped) or your application?

nghialv avatar May 10 '22 00:05 nghialv

I think it would be good to add the feature on the 2 charts :)

m4dm4rtig4n avatar May 10 '22 07:05 m4dm4rtig4n

@m4dm4rtig4n I see. I have just re-checked them and I found that the Piped agent chart is already containing the nodeSelector option. You can check it out here. https://github.com/pipe-cd/pipecd/blob/master/manifests/piped/values.yaml#L80

About the chart for the control plane, yes I think it does not exist currently. https://github.com/pipe-cd/pipecd/blob/master/manifests/pipecd/values.yaml

Could you please send a pull request to add that field?

nghialv avatar May 10 '22 07:05 nghialv

This issue is stale because it has been open 180 days with no activity. Remove stale label or comment or this will be closed in 7 days.

github-actions[bot] avatar Nov 15 '23 00:11 github-actions[bot]

This issue was closed because it has been stalled for 7 days with no activity. Feel free to reopen if still applicable.

github-actions[bot] avatar Nov 22 '23 00:11 github-actions[bot]