pipecd icon indicating copy to clipboard operation
pipecd copied to clipboard

Invalid k8s annotations are not cause error and simply ignored.

Open Hosshii opened this issue 3 years ago • 0 comments

What would you like to be added: k8s(and other kinds of application) spec validation.

Why is this needed: Following spec is invalid because while annotations' key and value must be string, ture is treated as bool.

apiVersion: apps/v1
kind: Deployment
metadata:
  annotations:
    pipecd.dev/sync-by-replace: true # must be "true"
...

But the spec like this are not cause validation error, and the invalid annotations are simply ignored.

Hosshii avatar Feb 10 '22 09:02 Hosshii