bender icon indicating copy to clipboard operation
bender copied to clipboard

Update the bender API to look more like jbender

Open cgordon opened this issue 8 years ago • 2 comments

The API for bender was created before the API for jbender (see https://github.com/pinterest/jbender). The API for jbender is more elegant and requires a LOT less memory allocations in the main loop (as it sends far fewer events). This would be a non-backwards compatible change, but given the way people vendor dependencies that should be alright for existing users.

cgordon avatar Oct 16 '17 18:10 cgordon

The API should probably also be tweaked to use time.Duration and other non-numeric types where appropriate.

nuance avatar Oct 17 '17 17:10 nuance

Agreed, in fact, I made very poor use of the Go type system in all of this project, and it is due for a major overhaul.

cgordon avatar Oct 18 '17 17:10 cgordon