PINRemoteImage icon indicating copy to clipboard operation
PINRemoteImage copied to clipboard

Removes the optimization to reduce the display links frame interval

Open garrettmoon opened this issue 6 years ago • 3 comments

The idea behind this optimization was to reduce the number of calls the display link would need for animated images which didn't draw every frame. But this has resulted in frames being dropped in certain cases where frameInterval isn't respected (see https://i.pinimg.com/originals/58/9c/e8/589ce828d2ef0797da0e85b1c6d2f2b3.gif)

Since the the display link fire method continues if we detect we're at the same image index as before, let's just remove this optimization.

garrettmoon avatar Aug 02 '19 21:08 garrettmoon

1 Warning
:warning: Any source code changes should have an entry in CHANGELOG.md or have #trivial in their title.

Generated by :no_entry_sign: Danger

ghost avatar Aug 02 '19 23:08 ghost

🚫 CI failed with log

ghost avatar Aug 02 '19 23:08 ghost

Is it possible to add a test covering this change?

bolsinga avatar May 21 '20 01:05 bolsinga