thread-stream icon indicating copy to clipboard operation
thread-stream copied to clipboard
verified publisher icon pinojs

Missing TypeScript types

Open kibertoad opened this issue 4 years ago • 6 comments

kibertoad avatar Jul 03 '21 18:07 kibertoad

@mcollina Is it too early to add types? How much breaking API changes are expected in this package in the nearby future?

kibertoad avatar Jul 04 '21 10:07 kibertoad

go for them!

mcollina avatar Jul 04 '21 13:07 mcollina

I'm adding a minimal version of types in this draft PR #71 , but I only added them because I needed types for testing a fix. They're not exposed in the package.json file, nor refined enough.

I prefer to not overdo them for this PR, but I could prepare a second one with a refined version, and expose them properly.

castarco avatar Mar 18 '22 20:03 castarco

@mcollina I noticed that ThreadStream (the return type of transport(..)) is any. Is there a reason we do not just set it to be DestinationStream? That would match with what pino(options: ... , stream: DestinationStream) expects.

magnusriga avatar Aug 21 '24 07:08 magnusriga

Because it's not.

mcollina avatar Aug 31 '24 14:08 mcollina