scim icon indicating copy to clipboard operation
scim copied to clipboard

Bug in FilterParser

Open fhanik opened this issue 8 years ago • 2 comments

https://github.com/UnboundID/scim/commit/9f1cf2d0f35f4295bdb166e06cd752156253b92a#diff-11245e1bab9fb9ac717dff7bf9c44793R377

When this commit was introduced, a SCIMFilter object will always return true for quoteFilterValue even if the value was not quoted.

For example

myattribute = "quoted-value" and myotherattribute = 0

This is a valid SCIM filter. But the above commit states that myotherattribute is a quoted value, but it never was.

The refactor treats everything as a String, and we no longer have a way to distinguish numerical values.

fhanik avatar Mar 01 '17 20:03 fhanik

Thanks for reporting this issue, I've created an internal JIRA issue to track the concern. I can confirm the issue results from changes made to the FilterParser#readValue method. There is no estimated time for resolution as the issue needs to be reviewed and prioritized.

richardcardona avatar Mar 01 '17 22:03 richardcardona

c66701f

The above commit should resolve the regression you encountered. If you can test with the master branch and confirm the fix, it can be included in the next release.

richardcardona avatar Mar 10 '17 14:03 richardcardona