tiflow icon indicating copy to clipboard operation
tiflow copied to clipboard

validator(dm): fix deadlock of validator

Open buchuitoudegou opened this issue 3 years ago • 3 comments

What problem does this PR solve?

Issue Number: close #7241

What is changed and how it works?

Check List

Tests

  • Unit test

Questions

Will it cause performance regression or break compatibility?
Do you need to update user documentation, design documentation or monitoring documentation?

Release note

 `None`.

buchuitoudegou avatar Sep 30 '22 02:09 buchuitoudegou

[REVIEW NOTIFICATION]

This pull request has been approved by:

  • D3Hunter
  • lance6716

To complete the pull request process, please ask the reviewers in the list to review by filling /cc @reviewer in the comment. After your PR has acquired the required number of LGTMs, you can assign this pull request to the committer in the list by filling /assign @committer in the comment to help you merge this pull request.

The full list of commands accepted by this bot can be found here.

Reviewer can indicate their review by submitting an approval review. Reviewer can cancel approval by submitting a request changes review.

ti-chi-bot avatar Sep 30 '22 02:09 ti-chi-bot

Codecov Report

Merging #7269 (50df47c) into master (d8fff7a) will increase coverage by 0.0360%. The diff coverage is 66.7984%.

Additional details and impacted files
Flag Coverage Δ
cdc 67.1918% <77.2727%> (-0.0237%) :arrow_down:
dm 51.9051% <52.8735%> (+0.0676%) :arrow_up:
engine 60.9712% <66.9902%> (+0.1131%) :arrow_up:

Flags with carried forward coverage won't be shown. Click here to find out more.

@@               Coverage Diff                @@
##             master      #7269        +/-   ##
================================================
+ Coverage   59.6043%   59.6403%   +0.0360%     
================================================
  Files           790        789         -1     
  Lines         91089      91091         +2     
================================================
+ Hits          54293      54327        +34     
+ Misses        32051      32014        -37     
- Partials       4745       4750         +5     

codecov-commenter avatar Oct 08 '22 04:10 codecov-commenter

/cc @D3Hunter

buchuitoudegou avatar Oct 08 '22 06:10 buchuitoudegou

/merge

lance6716 avatar Oct 10 '22 02:10 lance6716

This pull request has been accepted and is ready to merge.

Commit hash: 50df47c9d44085a84a62c6e081e2dbb1525fe5c0

ti-chi-bot avatar Oct 10 '22 02:10 ti-chi-bot

@buchuitoudegou: Your PR was out of date, I have automatically updated it for you.

At the same time I will also trigger all tests for you:

/run-all-tests

If the CI test fails, you just re-trigger the test that failed and the bot will merge the PR for you after the CI passes.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the ti-community-infra/tichi repository.

ti-chi-bot avatar Oct 10 '22 02:10 ti-chi-bot

/run-engine-integration-test

buchuitoudegou avatar Oct 10 '22 02:10 buchuitoudegou

In response to a cherrypick label: new pull request created: #7301.

ti-chi-bot avatar Oct 10 '22 02:10 ti-chi-bot

In response to a cherrypick label: new pull request created: #7302.

ti-chi-bot avatar Oct 10 '22 02:10 ti-chi-bot