tiflow icon indicating copy to clipboard operation
tiflow copied to clipboard

build(engine): move engine/deployements to deployments/engine

Open sleepymole opened this issue 3 years ago • 2 comments

What problem does this PR solve?

Issue Number: close https://github.com/pingcap/tiflow/issues/6737

What is changed and how it works?

Check List

Tests

  • Unit test
  • Integration test
  • Manual test (add detailed scripts or steps below)
  • No code

Questions

Will it cause performance regression or break compatibility?
Do you need to update user documentation, design documentation or monitoring documentation?

Release note

None

sleepymole avatar Aug 12 '22 10:08 sleepymole

[REVIEW NOTIFICATION]

This pull request has been approved by:

  • amyangfei
  • lance6716

To complete the pull request process, please ask the reviewers in the list to review by filling /cc @reviewer in the comment. After your PR has acquired the required number of LGTMs, you can assign this pull request to the committer in the list by filling /assign @committer in the comment to help you merge this pull request.

The full list of commands accepted by this bot can be found here.

Reviewer can indicate their review by submitting an approval review. Reviewer can cancel approval by submitting a request changes review.

ti-chi-bot avatar Aug 12 '22 10:08 ti-chi-bot

Codecov Report

Merging #6736 (9e0dd04) into master (2ea67ba) will increase coverage by 0.1174%. The diff coverage is 72.7554%.

Flag Coverage Δ
cdc 65.9353% <72.4786%> (+0.0672%) :arrow_up:
dm 52.0368% <88.8888%> (-0.0049%) :arrow_down:
engine 62.8071% <72.8000%> (+0.2709%) :arrow_up:

Flags with carried forward coverage won't be shown. Click here to find out more.

@@               Coverage Diff                @@
##             master      #6736        +/-   ##
================================================
+ Coverage   59.2138%   59.3312%   +0.1174%     
================================================
  Files           780        785         +5     
  Lines         88405      89366       +961     
================================================
+ Hits          52348      53022       +674     
- Misses        31415      31662       +247     
- Partials       4642       4682        +40     

codecov-commenter avatar Aug 12 '22 10:08 codecov-commenter

/merge

lance6716 avatar Aug 15 '22 01:08 lance6716

This pull request has been accepted and is ready to merge.

Commit hash: 9e0dd040828d33c97fed3d09529a85e725a94b5c

ti-chi-bot avatar Aug 15 '22 01:08 ti-chi-bot

@gozssky: Your PR was out of date, I have automatically updated it for you.

At the same time I will also trigger all tests for you:

/run-all-tests

If the CI test fails, you just re-trigger the test that failed and the bot will merge the PR for you after the CI passes.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the ti-community-infra/tichi repository.

ti-chi-bot avatar Aug 15 '22 01:08 ti-chi-bot