*: upgrade go1.24
What problem does this PR solve?
Issue Number: close #xxx
Problem Summary:
What changed and how does it work?
Check List
Tests
- [ ] Unit test
- [ ] Integration test
- [ ] Manual test (add detailed scripts or steps below)
- [ ] No need to test
- [ ] I checked and no code files have been changed.
Side effects
- [ ] Performance regression: Consumes more CPU
- [ ] Performance regression: Consumes more Memory
- [ ] Breaking backward compatibility
Documentation
- [ ] Affects user behaviors
- [ ] Contains syntax changes
- [ ] Contains variable changes
- [ ] Contains experimental features
- [ ] Changes MySQL compatibility
Release note
Please refer to Release Notes Language Style Guide to write a quality release note.
None
Codecov Report
:white_check_mark: All modified and coverable lines are covered by tests.
:white_check_mark: Project coverage is 73.2554%. Comparing base (bd49a62) to head (c9523b1).
:warning: Report is 518 commits behind head on master.
Additional details and impacted files
@@ Coverage Diff @@
## master #59015 +/- ##
================================================
+ Coverage 72.8567% 73.2554% +0.3987%
================================================
Files 1769 1769
Lines 486091 486111 +20
================================================
+ Hits 354150 356103 +1953
+ Misses 110280 108354 -1926
+ Partials 21661 21654 -7
| Flag | Coverage Δ | |
|---|---|---|
| integration | 42.2888% <ø> (?) |
Flags with carried forward coverage won't be shown. Click here to find out more.
| Components | Coverage Δ | |
|---|---|---|
| dumpling | 52.8700% <ø> (ø) |
|
| parser | ∅ <ø> (∅) |
|
| br | 46.3223% <ø> (+0.0102%) |
:arrow_up: |
:rocket: New features to boost your workflow:
- :snowflake: Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
- :package: JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.
From the Golang 1.24 release notes, we can see:
Runtime
Several performance improvements to the runtime have decreased CPU overheads by 2–3% on average across a suite of representative benchmarks. Results may vary by application. These improvements include a new builtin map implementation based on Swiss Tables, more efficient memory allocation of small objects, and a new runtime-internal mutex implementation.
The new builtin map implementation and new runtime-internal mutex may be disabled by setting GOEXPERIMENT=noswissmap and GOEXPERIMENT=nospinbitmutex at build time respectively.
In Go 1.24, the internal implementation of map has changed. This change will invalidate our existing memory statistics logic for the map structure.
Therefore, before officially switching to Go 1.24, we need to first modify the map memory statistics logic in the TiDB code to ensure compatibility with Go 1.24.
[APPROVALNOTIFIER] This PR is NOT APPROVED
This pull-request has been approved by: Once this PR has been reviewed and has the lgtm label, please assign bb7133 for approval. For more information see the Code Review Process. Please ensure that each of them provides their approval before proceeding.
The full list of commands accepted by this bot can be found here.
Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment
[FORMAT CHECKER NOTIFICATION]
Notice: To remove the do-not-merge/needs-linked-issue label, please provide the linked issue number on one line in the PR body, for example: Issue Number: close #123 or Issue Number: ref #456.
:open_book: For more info, you can check the "Contribute Code" section in the development guide.
Notice: To remove the do-not-merge/needs-tests-checked label, please finished the tests then check the finished items in description.
For example:
Tests
- [x] Unit test
- [ ] Integration test
- [ ] Manual test (add detailed scripts or steps below)
- [ ] No code
:open_book: For more info, you can check the "Contribute Code" section in the development guide.
@hawkingrei: The following test failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:
| Test name | Commit | Details | Required | Rerun command |
|---|---|---|---|---|
| fast_test_tiprow | c9523b13822dec092b717e9d31a8d891467f17ec | link | true | /test fast_test_tiprow |
Full PR test history. Your PR dashboard.
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.
@hawkingrei: The following tests failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:
| Test name | Commit | Details | Required | Rerun command |
|---|---|---|---|---|
| non-block-pull-unit-test-next-gen | c9523b13822dec092b717e9d31a8d891467f17ec | link | false | /test pull-unit-test-next-gen |
| idc-jenkins-ci-tidb/unit-test | c9523b13822dec092b717e9d31a8d891467f17ec | link | true | /test unit-test |
| pull-integration-realcluster-test-next-gen | c9523b13822dec092b717e9d31a8d891467f17ec | link | true | /test pull-integration-realcluster-test-next-gen |
| pull-unit-test-next-gen | c9523b13822dec092b717e9d31a8d891467f17ec | link | true | /test pull-unit-test-next-gen |
Full PR test history. Your PR dashboard.
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.