tidb icon indicating copy to clipboard operation
tidb copied to clipboard

planner: fix incorrect maintenance of `handleColHelper` for recursive CTE

Open time-and-fate opened this issue 1 year ago • 2 comments

What problem does this PR solve?

Issue Number: close #55666

Problem Summary:

What changed and how does it work?

Check List

Tests

  • [ ] Unit test
  • [x] Integration test
  • [ ] Manual test (add detailed scripts or steps below)
  • [ ] No need to test
    • [ ] I checked and no code files have been changed.

Side effects

  • [ ] Performance regression: Consumes more CPU
  • [ ] Performance regression: Consumes more Memory
  • [ ] Breaking backward compatibility

Documentation

  • [ ] Affects user behaviors
  • [ ] Contains syntax changes
  • [ ] Contains variable changes
  • [ ] Contains experimental features
  • [ ] Changes MySQL compatibility

Release note

Please refer to Release Notes Language Style Guide to write a quality release note.

None

time-and-fate avatar Aug 28 '24 16:08 time-and-fate

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Project coverage is 56.1953%. Comparing base (e9124dd) to head (c9d0d47). Report is 4 commits behind head on master.

Additional details and impacted files
@@                Coverage Diff                @@
##             master     #55732         +/-   ##
=================================================
- Coverage   72.8514%   56.1953%   -16.6561%     
=================================================
  Files          1601       1729        +128     
  Lines        445302     622110     +176808     
=================================================
+ Hits         324409     349597      +25188     
- Misses       100894     248845     +147951     
- Partials      19999      23668       +3669     
Flag Coverage Δ
integration 37.4003% <100.0000%> (?)
unit 72.1316% <100.0000%> (+0.1704%) :arrow_up:

Flags with carried forward coverage won't be shown. Click here to find out more.

Components Coverage Δ
dumpling 52.9567% <ø> (ø)
parser ∅ <ø> (∅)
br 52.8045% <ø> (+7.0278%) :arrow_up:

codecov[bot] avatar Aug 28 '24 16:08 codecov[bot]

Please add a description of how to handle CTE in the comments for the handleHelper attribute.

XuHuaiyu avatar Aug 30 '24 00:08 XuHuaiyu

/retest

time-and-fate avatar Aug 30 '24 14:08 time-and-fate

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: Rustin170506, winoros

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment Approvers can cancel approval by writing /approve cancel in a comment

ti-chi-bot[bot] avatar Sep 05 '24 17:09 ti-chi-bot[bot]

[LGTM Timeline notifier]

Timeline:

  • 2024-09-04 06:59:30.400385092 +0000 UTC m=+427694.918438014: :ballot_box_with_check: agreed by Rustin170506.
  • 2024-09-05 17:34:32.032588724 +0000 UTC m=+552196.550641648: :ballot_box_with_check: agreed by winoros.

ti-chi-bot[bot] avatar Sep 05 '24 17:09 ti-chi-bot[bot]

/retest

time-and-fate avatar Sep 06 '24 02:09 time-and-fate

/retest

time-and-fate avatar Sep 06 '24 04:09 time-and-fate

In response to a cherrypick label: new pull request created to branch release-6.5: #55896.

ti-chi-bot avatar Sep 06 '24 04:09 ti-chi-bot

In response to a cherrypick label: new pull request created to branch release-7.1: #55897.

ti-chi-bot avatar Sep 06 '24 04:09 ti-chi-bot

In response to a cherrypick label: new pull request created to branch release-7.5: #55898.

ti-chi-bot avatar Sep 06 '24 04:09 ti-chi-bot

In response to a cherrypick label: new pull request created to branch release-8.1: #55899.

ti-chi-bot avatar Sep 06 '24 04:09 ti-chi-bot