tidb icon indicating copy to clipboard operation
tidb copied to clipboard

*: fix unstable test in pull-lightning-integration-test

Open hawkingrei opened this issue 1 year ago • 6 comments

What problem does this PR solve?

Issue Number: close #xxx

Problem Summary:

What changed and how does it work?

Check List

Tests

  • [ ] Unit test
  • [ ] Integration test
  • [ ] Manual test (add detailed scripts or steps below)
  • [ ] No need to test
    • [ ] I checked and no code files have been changed.

Side effects

  • [ ] Performance regression: Consumes more CPU
  • [ ] Performance regression: Consumes more Memory
  • [ ] Breaking backward compatibility

Documentation

  • [ ] Affects user behaviors
  • [ ] Contains syntax changes
  • [ ] Contains variable changes
  • [ ] Contains experimental features
  • [ ] Changes MySQL compatibility

Release note

Please refer to Release Notes Language Style Guide to write a quality release note.

None

hawkingrei avatar Aug 28 '24 10:08 hawkingrei

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Project coverage is 56.6171%. Comparing base (3419bde) to head (1302fb3). Report is 7 commits behind head on master.

Additional details and impacted files
@@                Coverage Diff                @@
##             master     #55730         +/-   ##
=================================================
- Coverage   73.0085%   56.6171%   -16.3914%     
=================================================
  Files          1584       1734        +150     
  Lines        443036     625203     +182167     
=================================================
+ Hits         323454     353972      +30518     
- Misses        99870     247063     +147193     
- Partials      19712      24168       +4456     
Flag Coverage Δ
integration 38.5046% <100.0000%> (?)
unit 72.1022% <0.0000%> (-0.0621%) :arrow_down:

Flags with carried forward coverage won't be shown. Click here to find out more.

Components Coverage Δ
dumpling 52.9567% <ø> (ø)
parser ∅ <ø> (∅)
br 52.3135% <ø> (+6.8552%) :arrow_up:

codecov[bot] avatar Aug 28 '24 11:08 codecov[bot]

/test pull-lightning-integration-test

HuSharp avatar Aug 29 '24 02:08 HuSharp

@HuSharp: The specified target(s) for /test were not found. The following commands are available to trigger required jobs:

  • /test fast_test_tiprow
  • /test tidb_parser_test

Use /test all to run all jobs.

In response to this:

/test pull-lightning-integration-test

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

tiprow[bot] avatar Aug 29 '24 02:08 tiprow[bot]

/retest

hawkingrei avatar Aug 29 '24 10:08 hawkingrei

/retest

hawkingrei avatar Aug 29 '24 10:08 hawkingrei

/retest

hawkingrei avatar Sep 02 '24 07:09 hawkingrei

/retest

hawkingrei avatar Sep 02 '24 07:09 hawkingrei

[LGTM Timeline notifier]

Timeline:

  • 2024-09-02 07:07:16.118798478 +0000 UTC m=+255360.636851398: :ballot_box_with_check: agreed by lance6716.
  • 2024-09-02 07:24:33.583980259 +0000 UTC m=+256398.102033463: :ballot_box_with_check: agreed by D3Hunter.

ti-chi-bot[bot] avatar Sep 02 '24 07:09 ti-chi-bot[bot]

/hold

Waiting for the E2E test‘s result.

hawkingrei avatar Sep 02 '24 07:09 hawkingrei

/hold

lance6716 avatar Sep 02 '24 07:09 lance6716

/unhold

tested by internal E2E test, it is succeed.

hawkingrei avatar Sep 02 '24 09:09 hawkingrei

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: AilinKid, D3Hunter, lance6716

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment Approvers can cancel approval by writing /approve cancel in a comment

ti-chi-bot[bot] avatar Sep 02 '24 10:09 ti-chi-bot[bot]