tidb icon indicating copy to clipboard operation
tidb copied to clipboard

*: disable insert null to not-null column for single-row insertion in non-strict mode | tidb-test=pr/2410

Open joechenrh opened this issue 1 year ago • 11 comments

What problem does this PR solve?

Issue Number: close #55457, close #56381

Problem Summary:

What changed and how does it work?

Accroding to MySQL document, even in non-strict mode, single null value still can not be inserted into not-null column.

Check List

Tests

  • [ ] Unit test
  • [x] Integration test
  • [ ] Manual test (add detailed scripts or steps below)
  • [ ] No need to test
    • [ ] I checked and no code files have been changed.

Side effects

  • [ ] Performance regression: Consumes more CPU
  • [ ] Performance regression: Consumes more Memory
  • [ ] Breaking backward compatibility

Documentation

  • [ ] Affects user behaviors
  • [ ] Contains syntax changes
  • [ ] Contains variable changes
  • [ ] Contains experimental features
  • [ ] Changes MySQL compatibility

Release note

Please refer to Release Notes Language Style Guide to write a quality release note.

None

joechenrh avatar Aug 16 '24 09:08 joechenrh

Hi @joechenrh. Thanks for your PR.

PRs from untrusted users cannot be marked as trusted with /ok-to-test in this repo meaning untrusted PR authors can never trigger tests themselves. Collaborators can still trigger tests on the PR using /test all.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

tiprow[bot] avatar Aug 16 '24 09:08 tiprow[bot]

/ok-to-test

joechenrh avatar Aug 16 '24 11:08 joechenrh

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Project coverage is 74.9721%. Comparing base (8382fdb) to head (cc158dd). Report is 144 commits behind head on master.

Additional details and impacted files
@@               Coverage Diff                @@
##             master     #55477        +/-   ##
================================================
+ Coverage   72.8567%   74.9721%   +2.1153%     
================================================
  Files          1672       1717        +45     
  Lines        462738     474024     +11286     
================================================
+ Hits         337136     355386     +18250     
+ Misses       104829      96471      -8358     
- Partials      20773      22167      +1394     
Flag Coverage Δ
integration 49.8755% <92.8571%> (?)
unit 72.2780% <100.0000%> (+0.0408%) :arrow_up:

Flags with carried forward coverage won't be shown. Click here to find out more.

Components Coverage Δ
dumpling 52.7673% <ø> (ø)
parser ∅ <ø> (∅)
br 60.7951% <ø> (+15.6921%) :arrow_up:

codecov[bot] avatar Aug 16 '24 11:08 codecov[bot]

/retest

joechenrh avatar Oct 09 '24 02:10 joechenrh

/retest

joechenrh avatar Oct 09 '24 05:10 joechenrh

/retest

joechenrh avatar Oct 09 '24 05:10 joechenrh

/retest-required

joechenrh avatar Oct 09 '24 09:10 joechenrh

/cc @zanmato1984 @gmhdbjd

joechenrh avatar Oct 09 '24 11:10 joechenrh

PR needs rebase.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

ti-chi-bot[bot] avatar Oct 18 '24 10:10 ti-chi-bot[bot]

[LGTM Timeline notifier]

Timeline:

  • 2024-11-19 08:42:44.995047773 +0000 UTC m=+950527.185916764: :ballot_box_with_check: agreed by djshow832.
  • 2024-11-19 08:49:33.69586506 +0000 UTC m=+950935.886734054: :ballot_box_with_check: agreed by GMHDBJD.

ti-chi-bot[bot] avatar Nov 19 '24 08:11 ti-chi-bot[bot]

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: djshow832, GMHDBJD, XuHuaiyu

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment Approvers can cancel approval by writing /approve cancel in a comment

ti-chi-bot[bot] avatar Nov 19 '24 09:11 ti-chi-bot[bot]

/hold

please fill the checklist box and release note in the PR description.

wuhuizuo avatar Nov 19 '24 11:11 wuhuizuo

/unhold

djshow832 avatar Nov 19 '24 11:11 djshow832

In response to a cherrypick label: new pull request created to branch release-8.5: #57539.

ti-chi-bot avatar Nov 20 '24 05:11 ti-chi-bot

In response to a cherrypick label: new pull request created to branch release-7.5: #58044.

ti-chi-bot avatar Dec 06 '24 05:12 ti-chi-bot

In response to a cherrypick label: new pull request created to branch release-8.1: #58045.

ti-chi-bot avatar Dec 06 '24 05:12 ti-chi-bot

In response to a cherrypick label: new pull request created to branch release-6.5: #58046.

ti-chi-bot avatar Dec 06 '24 05:12 ti-chi-bot

In response to a cherrypick label: new pull request created to branch release-7.1: #58047.

ti-chi-bot avatar Dec 06 '24 05:12 ti-chi-bot