*: disable insert null to not-null column for single-row insertion in non-strict mode | tidb-test=pr/2410
What problem does this PR solve?
Issue Number: close #55457, close #56381
Problem Summary:
What changed and how does it work?
Accroding to MySQL document, even in non-strict mode, single null value still can not be inserted into not-null column.
Check List
Tests
- [ ] Unit test
- [x] Integration test
- [ ] Manual test (add detailed scripts or steps below)
- [ ] No need to test
- [ ] I checked and no code files have been changed.
Side effects
- [ ] Performance regression: Consumes more CPU
- [ ] Performance regression: Consumes more Memory
- [ ] Breaking backward compatibility
Documentation
- [ ] Affects user behaviors
- [ ] Contains syntax changes
- [ ] Contains variable changes
- [ ] Contains experimental features
- [ ] Changes MySQL compatibility
Release note
Please refer to Release Notes Language Style Guide to write a quality release note.
None
Hi @joechenrh. Thanks for your PR.
PRs from untrusted users cannot be marked as trusted with /ok-to-test in this repo meaning untrusted PR authors can never trigger tests themselves. Collaborators can still trigger tests on the PR using /test all.
I understand the commands that are listed here.
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.
/ok-to-test
Codecov Report
All modified and coverable lines are covered by tests :white_check_mark:
Project coverage is 74.9721%. Comparing base (
8382fdb) to head (cc158dd). Report is 144 commits behind head on master.
Additional details and impacted files
@@ Coverage Diff @@
## master #55477 +/- ##
================================================
+ Coverage 72.8567% 74.9721% +2.1153%
================================================
Files 1672 1717 +45
Lines 462738 474024 +11286
================================================
+ Hits 337136 355386 +18250
+ Misses 104829 96471 -8358
- Partials 20773 22167 +1394
| Flag | Coverage Δ | |
|---|---|---|
| integration | 49.8755% <92.8571%> (?) |
|
| unit | 72.2780% <100.0000%> (+0.0408%) |
:arrow_up: |
Flags with carried forward coverage won't be shown. Click here to find out more.
| Components | Coverage Δ | |
|---|---|---|
| dumpling | 52.7673% <ø> (ø) |
|
| parser | ∅ <ø> (∅) |
|
| br | 60.7951% <ø> (+15.6921%) |
:arrow_up: |
/retest
/retest
/retest
/retest-required
/cc @zanmato1984 @gmhdbjd
PR needs rebase.
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.
[LGTM Timeline notifier]
Timeline:
[APPROVALNOTIFIER] This PR is APPROVED
This pull-request has been approved by: djshow832, GMHDBJD, XuHuaiyu
The full list of commands accepted by this bot can be found here.
The pull request process is described here
- ~~OWNERS~~ [GMHDBJD,XuHuaiyu,djshow832]
- ~~pkg/ddl/OWNERS~~ [GMHDBJD]
- ~~pkg/expression/OWNERS~~ [XuHuaiyu]
- ~~pkg/lightning/OWNERS~~ [GMHDBJD]
- ~~pkg/table/OWNERS~~ [GMHDBJD]
Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment
/hold
please fill the checklist box and release note in the PR description.
/unhold
In response to a cherrypick label: new pull request created to branch release-8.5: #57539.
In response to a cherrypick label: new pull request created to branch release-7.5: #58044.
In response to a cherrypick label: new pull request created to branch release-8.1: #58045.
In response to a cherrypick label: new pull request created to branch release-6.5: #58046.
In response to a cherrypick label: new pull request created to branch release-7.1: #58047.