tidb icon indicating copy to clipboard operation
tidb copied to clipboard

util: record more information before OOM

Open mengxin9014 opened this issue 3 years ago • 3 comments

What problem does this PR solve?

Issue Number: close #https://github.com/pingcap/tidb/issues/37409

Problem Summary:

What is changed and how it works?

record more information:

  1. topN-mem-consumer
  • current explain analyze
  • desensitized SQL text
  1. memory related variables
  • system variables
  • session variables

modify record logic:

  • we will record the information if (current_mem_usage_ratio > 70% && (current_time - last_record_time > 60s || current_mem_usage_ratio - last_record_mem_usage_ratio > 10%))

Check List

Tests

  • [ ] Unit test
  • [ ] Integration test
  • [ ] Manual test (add detailed scripts or steps below)
  • [ ] No code

Side effects

  • [ ] Performance regression: Consumes more CPU
  • [ ] Performance regression: Consumes more Memory
  • [ ] Breaking backward compatibility

Documentation

  • [ ] Affects user behaviors
  • [ ] Contains syntax changes
  • [ ] Contains variable changes
  • [ ] Contains experimental features
  • [ ] Changes MySQL compatibility

Release note

Please refer to Release Notes Language Style Guide to write a quality release note.

record more information before OOM.

mengxin9014 avatar Sep 20 '22 08:09 mengxin9014

[REVIEW NOTIFICATION]

This pull request has been approved by:

  • XuHuaiyu
  • wshwsh12

To complete the pull request process, please ask the reviewers in the list to review by filling /cc @reviewer in the comment. After your PR has acquired the required number of LGTMs, you can assign this pull request to the committer in the list by filling /assign @committer in the comment to help you merge this pull request.

The full list of commands accepted by this bot can be found here.

Reviewer can indicate their review by submitting an approval review. Reviewer can cancel approval by submitting a request changes review.

ti-chi-bot avatar Sep 20 '22 08:09 ti-chi-bot

/cc @XuHuaiyu

mengxin9014 avatar Sep 20 '22 09:09 mengxin9014

/cc @wshwsh12

mengxin9014 avatar Sep 20 '22 09:09 mengxin9014

/run-all-tests

mengxin9014 avatar Sep 28 '22 04:09 mengxin9014

/cc @wshwsh12

mengxin9014 avatar Oct 09 '22 02:10 mengxin9014

/run-build

wuhuizuo avatar Oct 09 '22 05:10 wuhuizuo

/merge

XuHuaiyu avatar Oct 12 '22 02:10 XuHuaiyu

This pull request has been accepted and is ready to merge.

Commit hash: 2618c0931f3727adfb65492dff183652aaf3cadd

ti-chi-bot avatar Oct 12 '22 02:10 ti-chi-bot

@mengxin9014: Your PR was out of date, I have automatically updated it for you.

At the same time I will also trigger all tests for you:

/run-all-tests

If the CI test fails, you just re-trigger the test that failed and the bot will merge the PR for you after the CI passes.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the ti-community-infra/tichi repository.

ti-chi-bot avatar Oct 12 '22 02:10 ti-chi-bot