tidb-operator icon indicating copy to clipboard operation
tidb-operator copied to clipboard

added crds to tidb-operator charts for install it automic

Open zerix opened this issue 3 years ago • 3 comments

What problem does this PR solve?

Closes #4901(issue number)

What is changed and how does it work?

  1. tidb-operator charts added a crds path.
  2. added manifest/crd.yml file to tidb-operator/crds/.

Code changes

  • [ ] Has Go code change
  • [ ] Has CI related scripts change

Tests

  • [ ] Unit test
  • [ ] E2E test
  • [x] Manual test
  • [ ] No code

Side effects

  • [ ] Breaking backward compatibility
  • [ ] Other side effects:

Related changes

  • [ ] Need to cherry-pick to the release branch
  • [x] Need to update the documentation

Release Notes

Please refer to Release Notes Language Style Guide before writing the release note.


zerix avatar Feb 24 '23 02:02 zerix

[REVIEW NOTIFICATION]

This pull request has not been approved.

To complete the pull request process, please ask the reviewers in the list to review by filling /cc @reviewer in the comment. After your PR has acquired the required number of LGTMs, you can assign this pull request to the committer in the list by filling /assign @committer in the comment to help you merge this pull request.

The full list of commands accepted by this bot can be found here.

Reviewer can indicate their review by submitting an approval review. Reviewer can cancel approval by submitting a request changes review.

ti-chi-bot avatar Feb 24 '23 02:02 ti-chi-bot

CLA assistant check
Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.


zery seems not to be a GitHub user. You need a GitHub account to be able to sign the CLA. If you have already a GitHub account, please add the email address used for this commit to your account.
You have signed the CLA already but the status is still pending? Let us recheck it.

CLAassistant avatar Feb 24 '23 02:02 CLAassistant

CRD in Helm chart may not work well when updating the Helm chart, ref https://github.com/helm/helm/issues/8668

So I prefer to do not to include the CRD in the Helm chart.

csuzhangxc avatar Mar 06 '23 08:03 csuzhangxc