tidb-operator icon indicating copy to clipboard operation
tidb-operator copied to clipboard

[WIP]Deprecate unnecessary Helm Chart deployment

Open mianhk opened this issue 4 years ago • 4 comments

What problem does this PR solve?

Deprecate parts of unnecessary Helm Chart deployment, ref: https://github.com/pingcap/tidb-operator/issues/4254. On the other hand, the PR(#4170 ) needs to fix some of e2e tests. ref: https://github.com/pingcap/tidb-operator/pull/4170#issuecomment-990538602.

The following parts have been deprecated in this PR:

  • deprecate TidbClusterConfig in e2e tests.
  • deprecate installing pump by Helm in e2e tests.
  • delete other unused files and functions.

What is changed and how does it work?

Code changes

  • [x] Has Go code change
  • [ ] Has CI related scripts change

Tests

  • [x] Unit test
  • [x] E2E test
  • [ ] Manual test
  • [ ] No code

Side effects

  • [ ] Breaking backward compatibility
  • [x] Other side effects:
  • I delete the file docs/stability-test-cookbook.md and test files around it. Don't know if there are any other effects.

Related changes

  • [ ] Need to cherry-pick to the release branch
  • [ ] Need to update the documentation

Release Notes

Please refer to Release Notes Language Style Guide before writing the release note.

Deprecate unnecessary Helm Chart deployment.

mianhk avatar Dec 22 '21 03:12 mianhk

[REVIEW NOTIFICATION]

This pull request has not been approved.

To complete the pull request process, please ask the reviewers in the list to review by filling /cc @reviewer in the comment. After your PR has acquired the required number of LGTMs, you can assign this pull request to the committer in the list by filling /assign @committer in the comment to help you merge this pull request.

The full list of commands accepted by this bot can be found here.

Reviewer can indicate their review by submitting an approval review. Reviewer can cancel approval by submitting a request changes review.

ti-chi-bot avatar Dec 22 '21 03:12 ti-chi-bot

Codecov Report

Merging #4319 (422c5bd) into master (e07e29d) will decrease coverage by 0.01%. The diff coverage is n/a.

@@            Coverage Diff             @@
##           master    #4319      +/-   ##
==========================================
- Coverage   62.58%   62.57%   -0.02%     
==========================================
  Files         183      183              
  Lines       19452    19452              
==========================================
- Hits        12174    12172       -2     
- Misses       6145     6146       +1     
- Partials     1133     1134       +1     
Flag Coverage Δ
unittest 62.57% <ø> (-0.02%) :arrow_down:

codecov-commenter avatar Dec 22 '21 03:12 codecov-commenter

@mianhk CI failed

KanShiori avatar Dec 22 '21 05:12 KanShiori

@mianhk: PR needs rebase.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

ti-chi-bot avatar Feb 15 '22 21:02 ti-chi-bot