parser icon indicating copy to clipboard operation
parser copied to clipboard

fixed 'bad access: nil dereference' when calling Error() method if it…

Open henng opened this issue 6 years ago • 5 comments

SEE #576

henng avatar Oct 12 '19 08:10 henng

Codecov Report

Merging #577 into master will decrease coverage by 0.01%. The diff coverage is 50%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #577      +/-   ##
==========================================
- Coverage   71.82%   71.81%   -0.02%     
==========================================
  Files          32       32              
  Lines        7834     7838       +4     
==========================================
+ Hits         5627     5629       +2     
- Misses       1676     1677       +1     
- Partials      531      532       +1
Impacted Files Coverage Δ
terror/terror.go 73.43% <50%> (-0.76%) :arrow_down:
ast/functions.go 76.74% <0%> (ø) :arrow_up:

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update cbfc40a...4a34588. Read the comment docs.

codecov[bot] avatar Oct 12 '19 08:10 codecov[bot]

这个现在有啥别的修改?model/ddl中的job也遇到这个问题。

import (
	"github.com/pingcap/parser/model"
	"testing"
)

func TestJob(t *testing.T) {
	j:=model.Job{}
	t.Logf("%v",j)
}

由于job中的error为nil也是这个问题。

jyno12 avatar Mar 19 '21 06:03 jyno12

Ping @henng ?

tiancaiamao avatar Mar 25 '21 08:03 tiancaiamao

@henng: PR needs rebase.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

ti-chi-bot avatar Jul 16 '21 20:07 ti-chi-bot