parser icon indicating copy to clipboard operation
parser copied to clipboard

Add CannotInsertFlag to indicate that this table cannot be inserted

Open 7yyo opened this issue 5 years ago • 2 comments

What problem does this PR solve?

Include no_zero_date in sqlmode, these scenarios should fail to add column:

create table t (id int);
insert into t values(1);
alter table t add column a date not null;
alter table t add column a date not null;

Considering that data may be written during the DDL state change phase, need a flag to prevent data insert during this period. So add this table level flag.

What is changed and how it works?

Check List

Tests

  • No code

Code changes

  • Has exported variable/fields change

Side effects

Related changes

7yyo avatar Dec 19 '20 13:12 7yyo

@bb7133 PTAL

7yyo avatar Dec 19 '20 13:12 7yyo

@7yyo: PR needs rebase.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

ti-chi-bot avatar Jul 16 '21 20:07 ti-chi-bot