br icon indicating copy to clipboard operation
br copied to clipboard

restore: Adding table empty check before starting full restore operation

Open feniljain opened this issue 4 years ago • 4 comments

What problem does this PR solve?

https://github.com/pingcap/br/issues/801

What is changed and how it works?

A check for total bytes is kept on the tables and checked how many are filled, and the filled tables are returned, where further execution is stopped if there are any filled tables present.

Check List

Tests

  • Manual test (add detailed scripts or steps below)
  • Follow instructions from README.md to have the setup ready, take backup and do not drop databases and run the br restore command

Code changes

  • Has exported function/method change

Side effects

  • Increased code complexity

Release Note

  • No release note

feniljain avatar Mar 28 '21 08:03 feniljain

[REVIEW NOTIFICATION]

This pull request has not been approved.

To complete the pull request process, please ask the reviewers in the list to review by filling /cc @reviewer in the comment. After your PR has acquired the required number of LGTMs, you can assign this pull request to the committer in the list by filling /assign @committer in the comment to help you merge this pull request.

The full list of commands accepted by this bot can be found here.

Reviewer can indicate their review by writing /lgtm in a comment. Reviewer can cancel approval by writing /lgtm cancel in a comment.

ti-chi-bot avatar Mar 28 '21 08:03 ti-chi-bot

CLA assistant check
All committers have signed the CLA.

CLAassistant avatar Mar 28 '21 08:03 CLAassistant

Welcome @feniljain!

It looks like this is your first PR to pingcap/br 🎉.

I'm the bot to help you request reviewers, add labels and more, See available commands.

We want to make sure your contribution gets all the attention it needs!



Thank you, and welcome to pingcap/br. :smiley:

ti-chi-bot avatar Mar 28 '21 08:03 ti-chi-bot

@feniljain: PR needs rebase.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

ti-chi-bot avatar May 22 '21 01:05 ti-chi-bot