DNA-Diffusion icon indicating copy to clipboard operation
DNA-Diffusion copied to clipboard

Use hydra for configs

Open ssenan opened this issue 1 year ago • 4 comments

ssenan avatar Jul 30 '24 15:07 ssenan

We can use the rebased version of #274, which adds this.

cameronraysmith avatar Jul 30 '24 16:07 cameronraysmith

@cameronraysmith I was actually thinking of going back to using plain hydra rather than hydra-zen since I find it a little more intuitive. I can put a preliminary structure together and integrate it with your workflow cli.

ssenan avatar Jul 30 '24 17:07 ssenan

Sure, we can easily use them together. In that case, I'd recommend just adding your intended support for non-hydra-zen hydra in a separate PR and I'll rebase #274 on it to make sure they won't conflict with each other. I unlinked #274 from this issue.

cli mapping to base/overridable configs

there can initially/eventually be a dnadiffusion cli command that points to regular hydra and something else like dnadiffusionzen that points to the hydra-zen version

it's not straightforward to integrate hydra and (rich-)click, but if that eventually works they could become command (sub)groups

  • dnadiffusion hydra ...
  • dnadiffusion zen ...

which would be much nicer, but is more complex to set up

for your PR, I don't even think there needs to necessarily even be a named cli script at all unless you want to include it

cameronraysmith avatar Jul 30 '24 17:07 cameronraysmith

This issue is stale because it has been open for 60 days with no activity.

github-actions[bot] avatar Sep 29 '24 02:09 github-actions[bot]

This issue was closed because it has been inactive for 7 days since being marked as stale.

github-actions[bot] avatar Oct 07 '24 02:10 github-actions[bot]