pimutils
completed todos should be ~~striked through~~
We should be able to review what we have done today, sometimes we need to modify things we have done, so it would be a nice idea to show the todos which have been completed at the bottom of the list with a ~~strikethrough~~ and also, we all enjoy seeing what we accomplished today :wink: .
Apart from this, thanks @untitaker @hobarrera and all other contributors for making my life so simple. todoman is simply amazing. :+1:
We should perhaps show them only for some time, which can be configured through todoman.conf
Your proposal consists of two parts:
- Show done todos for a while in the main listing.
- Use strikethrough to mark done todos.
Re 1.), This probably makes todoman a bit slower since the database query gets more complex. Note that you can already show done todos using todo list --all or todo list --done-only. I think it would be nice to have some sort of productivity tracker (similar to GitHub Pulse) as part of todoman, but as a separate command such that the normal todo list + todo done workflow doesn't query for data I don't care about at the moment.
Re 2.), see https://github.com/pimutils/khal/issues/580 for information on strikethrough-support in terminals. Strikethrough text may not work in all terminals. But since done todos are already marked with a leading [X], it is not a problem if the terminal doesn't support strikethrough.
Thanks for giving it a thought!
Re 1.), This probably makes todoman a bit slower since the database query gets more complex.
IMHO, we can perhaps give user an option to choose between the two, we can add a warning which would state that todoman gets somewhat slow if you set show-done-todos to true.
Ok so todo list --all --sort=-completed_at is already close to what you want. We will need a way to trunchate the list of done todos, and to allow you to set those options as default.
Regarding strikethrough, I'd much rather use that for CANCELLED todos, and just show done todos "checked" as they are now.
We can make the default command configurable, which covers your needs, since you already have flags to show the listing you want.
Keep in mind that the Click release cycle is very slow (slower than any maintainer would like), and then there are possibly delays by distros, so it might make sense to hardcode this in todoman (especially if it's such a minor feature)
On Tue, May 30, 2017 at 01:50:40PM -0700, Hugo Osvaldo Barrera wrote:
This depends on pallets/click#805.
-- You are receiving this because you were mentioned. Reply to this email directly or view it on GitHub: https://github.com/pimutils/todoman/issues/218#issuecomment-305004241
Hhmm.. Maybe we can patch it in ourselves in the meantime?
Thanks for the heads up.
I don't think monkeypatching is really necessary here. I would generally avoid it.