khal 705

theme choice added for config file.

Mar 28 '20 19:03 pizzacoca

while coding I realized that my method is_theme in utils.py could parse colors.py nor khal.spec to check correct value. Is that(s desirable ? For this time I use the same way other check methods.

Mar 28 '20 20:03 pizzacoca

Thank you for this PR and sorry for not looking at this for > 2 years.

I don't think we need the test for checking for valid color schemes as configobj already does this for us. Am I missing something?

May 06 '22 15:05 geier

Any chance on merging this?

Jul 31 '22 15:07 fullstopslash

> git fetch origin pull/705/head
fatal: couldn't find remote ref pull/705/head

> git fetch origin pull/1005/head
From github.com:pimutils/khal
 * branch            refs/pull/1005/head -> FETCH_HEAD

I can't pull / checkout this specific PR to rebase/merge locally.

Jul 31 '22 16:07 WhyNotHugo

Any chance on merging this?

What problem does this PR solve for you?

Aug 30 '22 21:08 geier

I thought this PR adds the ability to define colorscheme in the config file. That would be rather snappy, and generally accepted as standard feature among command-line apps. It's kind of a pain to manually edit my colours.py every time I update ikhal.

Aug 31 '22 17:08 fullstopslash

This PR sounds like a first step for what you want -- it still doesn't allow defining new themes in user-defined locations, just picking one of the buit-in themes via the config file.

Aug 31 '22 20:08 WhyNotHugo

I think this can be closed in favour of https://github.com/pimutils/khal/pull/1279

Sep 18 '23 08:09 choucavalier