data-hub icon indicating copy to clipboard operation
data-hub copied to clipboard

[Improvement]: inconvenient namespace for datahub:graphql:rebuild-definitions command

Open jeykodev opened this issue 3 years ago • 1 comments

Improvement description

After changing my PIMCORE_WRITE_TARGET_DATA_HUB from symfony-config to settings-store (see Docs) I looked for a possibility to rebuild the definitions, so the configuration will be initial saved in the database instead of config files.

I've found the metioned command but it has the namespace graphql and since I'm using the Data Importer, I thought this will be not an option.

After that, I looked into the command and found out, that no additional checks for the specific configuration type graphql are implemented. At the end the command does rebuild every configuration type, not only graphql.

So I would suggest to remove the graphql namespace from the command and adapt the description and documentation.

If you guys agree, I can make a PR.

jeykodev avatar Mar 07 '22 09:03 jeykodev

@jeykodev Thank you for reporting, we would glad to see a PR about the change. I have also got a tip that this change may need a BC Layer/Alias to avoid any BC Break, hope this would help you as well when making the PR.

kingjia90 avatar Mar 07 '22 12:03 kingjia90