data-hub icon indicating copy to clipboard operation
data-hub copied to clipboard

Proposal: Be able to filter/search elements by key attribute

Open marcogonzalo opened this issue 5 years ago • 6 comments

Using key attribute as a filter could make simpler some listings like searching an specific category from its slug (the key attribute, for example) or instead of its id, because sometimes the id is not available in the workflow data. Key is an unique attribute so this could be work.

marcogonzalo avatar Nov 26 '20 11:11 marcogonzalo

@marcogonzalo makes sense, do you want to volunteer and provide a PR?

weisswurstkanone avatar Nov 26 '20 11:11 weisswurstkanone

Sorry for the late response. Let me talk with my team. We are using Pimcore, but we are not programming on PHP.

marcogonzalo avatar Dec 09 '20 19:12 marcogonzalo

@marcogonzalo Great, many thanks! Awaiting your feedback 👍

weisswurstkanone avatar Dec 10 '20 09:12 weisswurstkanone

Hello, @weisswurstkanone. My partner @PanchoMrlda is going to try to do this. Do you have some orientations about it? It's our first time on it and we need to try to make it quickly :-$

marcogonzalo avatar Jan 07 '21 16:01 marcogonzalo

I would start here (extending the schema) https://github.com/pimcore/data-hub/blob/18f0a8618be0a7659f86c81a3ca542280130300a/src/GraphQL/Query/QueryType.php#L277

and here (doing the filtering)

https://github.com/pimcore/data-hub/blob/58414f5c996087bdad7189d0a7c9a10503a3337b/src/GraphQL/Resolver/QueryType.php#L336

weisswurstkanone avatar Jan 14 '21 11:01 weisswurstkanone

Thanks a lot for reporting the issue. We did not consider the issue as "Pimcore:Priority", "Pimcore:ToDo" or "Pimcore:Backlog", so we're not going to work on that anytime soon. Please create a pull request to fix the issue if this is a bug report. We'll then review it as quickly as possible. If you're interested in contributing a feature, please contact us first here before creating a pull request. We'll then decide whether we'd accept it or not. Thanks for your understanding.

github-actions[bot] avatar Jan 21 '24 07:01 github-actions[bot]