data-hub icon indicating copy to clipboard operation
data-hub copied to clipboard

Consistent IDs

Open julkue opened this issue 5 years ago • 2 comments

Create an object type "Product", then you'll get at least two methods automatically:

  1. getProduct
  2. getProductListing

This is fine. However, getProduct requires an Integer as the ID, whereas getProductListing only accepts a string with comma separated values instead of an array.

Anmerkung 2020-08-13 134747 Anmerkung 2020-08-13 134847

Both, from my understanding, should rather support the actual response type of ID, which is:

Anmerkung 2020-08-13 134945

Also getProductListing should not have comma separeted IDs but an array of IDs.

julkue avatar Aug 13 '20 11:08 julkue

A PR not causing a BC break is welcome :-)

weisswurstkanone avatar Aug 17 '20 09:08 weisswurstkanone

Thanks a lot for reporting the issue. We did not consider the issue as "Pimcore:Priority", "Pimcore:ToDo" or "Pimcore:Backlog", so we're not going to work on that anytime soon. Please create a pull request to fix the issue if this is a bug report. We'll then review it as quickly as possible. If you're interested in contributing a feature, please contact us first here before creating a pull request. We'll then decide whether we'd accept it or not. Thanks for your understanding.

github-actions[bot] avatar Jan 21 '24 07:01 github-actions[bot]