Player icon indicating copy to clipboard operation
Player copied to clipboard

Hello, macOS 👋 (& system-supplied playback controls)

Open chriszielinski opened this issue 7 years ago • 2 comments

⚠️ Warning: this version has breaking changes. ⚠️

  • Full cross-platform support (macOS/iOS/tvOS).
    • Minimum deployment targets:
      • iOS 9.0
      • tvOS 9.0
      • macOS 10.10
  • System-supplied playback controls.
  • Refactor delegate protocols & FillMode to follow Swift nomenclature.
  • Add a few basic test cases (need a lot more).
  • Update readme.
  • Complete Travis CI suite (s/o to Regex for their Rakefile).
  • Carthage support.
  • Probably other stuff too, I don't remember.

Still needs

  • More test cases!!!!

lol meme

  • AVPlayerViewController implementation can be cleaned up. The double nested view controllers rub me the wrong way.
  • Did I already mention more test cases? Cause definitely that.

Thoughts? Comments? Concerns?

chriszielinski avatar Jun 23 '18 02:06 chriszielinski

hey, greatly appreciate the contributions. i typically prefer smaller PR's but i'll have to go through this and @addbrick contributions. i also need to split out the newer swift version changes to a new branch.

piemonte avatar Jun 23 '18 16:06 piemonte

Is there a reason this never got merged? I actually misunderstood the purpose of this entire library and when it said "customizable UI and user interaction" I figured it would have nice default custom video playback controls, and that I'd be able to extend those to fit my needs. This seems like the main value add of a custom video player, no?

Since this is so old and has tons of conflicts now, I'm not planning to reply on this being merged any time soon. Do any of you know of alternative packages that offer custom video controls without needing to use AVPlayerViewController's UI (which is non-configurable) @piemonte @chriszielinski?

tsheaff avatar Sep 24 '21 10:09 tsheaff