Guiders-JS icon indicating copy to clipboard operation
Guiders-JS copied to clipboard

Responsive design improvement suggestion

Open ptolp opened this issue 13 years ago • 0 comments

I'm planning to use your great jQuery plugin for a web service which uses RWD pattern. Guiders would work greatly for with just a few changes to JS code:

Change parameter

width: 400,

to

width: "400px",
maxWidth: "80%",

Then change

myGuider.elem.css("width", myGuider.width + "px");

to

myGuider.elem.css("width", myGuider.width);
myGuider.elem.css("maxWidth", myGuider.maxWidth);

This should do it. Now guiders are newer wider than viewport. Why should the width have also unit? Because it allows using e.g. "20em" instead of pixels, which ensures good text legibility.

Additionally, images inside a guider can be forced to fit to the width of guider in the CSS file with

.guider_content img {max-width:100%}

But IMO this could also be left to developer to choose.

ptolp avatar Jul 24 '12 10:07 ptolp