JavaScriptEnhancements icon indicating copy to clipboard operation
JavaScriptEnhancements copied to clipboard

Unused variables

Open ilearnio opened this issue 8 years ago • 22 comments

I just tested it a bit on a new updated version (0.13.14) and there's a couple more issues with unused variables.

3

And another caused by mixing return + template literal.

4

ilearnio avatar Jan 24 '18 09:01 ilearnio

5

ilearnio avatar Jan 24 '18 09:01 ilearnio

@ilearnio ok! The problem is that there could be so many cases! Thanks for your support!! 👍

pichillilorenzo avatar Jan 24 '18 12:01 pichillilorenzo

Updated! 👍

pichillilorenzo avatar Jan 25 '18 01:01 pichillilorenzo

Fantastic! Thanks!

ilearnio avatar Jan 25 '18 10:01 ilearnio

Hi, thanks for the awesome package. And there is still an issue. Case: screenshot from 2018-01-28 23-08-50 when used function arguments destructuring.

talgat-ruby avatar Jan 28 '18 17:01 talgat-ruby

@talgat-ruby Ok, I will check about that!

pichillilorenzo avatar Jan 28 '18 17:01 pichillilorenzo

@talgat-ruby Try the new version 0.15.0 and let me know!

pichillilorenzo avatar Feb 11 '18 18:02 pichillilorenzo

Hi @pichillilorenzo . Thanks yeah the problem resolved. But it was just removed. For example screenshot from 2018-02-13 12-48-18

The props probably must light, because we do not use it. Thanks.

P.S. I am not good with python, otherwise I would love to help you with improvements of the package

talgat-ruby avatar Feb 13 '18 06:02 talgat-ruby

Mmmm yeah I didn't consider class properties! I will check also about that thanks 👍

pichillilorenzo avatar Feb 13 '18 07:02 pichillilorenzo

One more case code boxes meetyourstar-admin src renderer store

ilearnio avatar Feb 13 '18 07:02 ilearnio

1

ilearnio avatar Feb 13 '18 09:02 ilearnio

Found another one. Happens only when there is an exclamation mark in if statement.

3

ilearnio avatar Feb 19 '18 14:02 ilearnio

@ilearnio ok, sorry if it is taking time to release the new update but i'm refactoring all the code in certain way that it won't require anymore my "workaround" described in the CONTRIBUTING.md file, in order to let people understand better all of my code!

pichillilorenzo avatar Feb 19 '18 14:02 pichillilorenzo

@pichillilorenzo it's ok. I just posting you issues I find

ilearnio avatar Feb 19 '18 14:02 ilearnio

I have updated it!

pichillilorenzo avatar Mar 11 '18 22:03 pichillilorenzo

It doesn't check used variables in flow's type annotations. (v0.16.1)

array annotation args properties annotations

also seems like it can't see an used var in if condition

unused var in if unused var message

Ok I will check about that! 👍

pichillilorenzo avatar Mar 18 '18 12:03 pichillilorenzo

and in extends

unused vars in extends msg of unused vars in extends

also seems like it can't see an used var in if condition

it's only with ! before a variable

Updated to 0.16.12!

pichillilorenzo avatar Mar 29 '18 15:03 pichillilorenzo

but

array annotation

still not fixed

enhanceerror

i noticed it marks variables or anything actually as unused when its exported this way

ChuksFestus avatar Aug 14 '18 07:08 ChuksFestus