piccolo_api icon indicating copy to clipboard operation
piccolo_api copied to clipboard

enable user creation and editing

Open sinisaos opened this issue 3 years ago • 3 comments

Enabled user creation and editing in Piccolo Admin

sinisaos avatar Jun 25 '22 06:06 sinisaos

Codecov Report

Merging #158 (b643e95) into master (ef105f7) will increase coverage by 0.12%. The diff coverage is 89.47%.

@@            Coverage Diff             @@
##           master     #158      +/-   ##
==========================================
+ Coverage   92.10%   92.23%   +0.12%     
==========================================
  Files          32       32              
  Lines        1774     1789      +15     
==========================================
+ Hits         1634     1650      +16     
+ Misses        140      139       -1     
Impacted Files Coverage Δ
piccolo_api/crud/endpoints.py 95.37% <89.47%> (+0.40%) :arrow_up:

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

codecov-commenter avatar Jun 25 '22 06:06 codecov-commenter

@dantownsend I think we don't need this and this anymore.

sinisaos avatar Jul 10 '22 06:07 sinisaos

@sinisaos Yes, they can be removed - don't think they'll be used.

dantownsend avatar Jul 10 '22 07:07 dantownsend

@sinisaos I'm a bit confused why MyPy is failing in GitHub Actions. It works OK for me locally. Is it the same for you?

dantownsend avatar Sep 26 '22 20:09 dantownsend

The MyPy errors are when the latest version of fastapi is installed.

dantownsend avatar Sep 26 '22 21:09 dantownsend

@sinisaos Sorry for the delay on this - I thought we already merged it in.

dantownsend avatar Sep 26 '22 21:09 dantownsend

@dantownsend No worries. When you have time, look at the other PRs in Piccolo Api, and also in Piccolo Admin, where we have several stale PRs.

sinisaos avatar Sep 27 '22 04:09 sinisaos