benchmark icon indicating copy to clipboard operation
benchmark copied to clipboard

Fix: missing gravity term in set_trajectory() function

Open marvin-oh opened this issue 1 year ago • 2 comments

Description

Fixes a bug in SimpleTrajectoryPlanner.set_trajectory() function. There was a missing term for gravity in the calculation of the y-axis position of the parabolic equation.

Fixes #8

Type of change

  • [x] Bug fix
  • [ ] New feature
  • [ ] Breaking change

marvin-oh avatar Jun 06 '24 07:06 marvin-oh

@marvin-oh Did you need to make any changes to successfully run RandomAgent or PigShooter?

tellarin avatar Jul 22 '25 08:07 tellarin

I found that both RandomAgent and PigShooter, which use SimpleTrajectoryPlanner.set_trajectory(), are not hitting the target location exactly. After applying the revised code, they reach the intended point precisely.

But, I recommend verifying it in your own environment since this work was done quite long ago.

marvin-oh avatar Jul 23 '25 07:07 marvin-oh