csslayout icon indicating copy to clipboard operation
csslayout copied to clipboard

CSS Grid for `Card layout`

Open Xaviju opened this issue 4 years ago • 4 comments

I'd like to know why this repo is not using CSS grid for card layout instead of flex.

Current code displays the grid using flex as here: https://github.com/phuoc-ng/csslayout/blob/88200a698329be14ddc916053266ac788697de8f/client/patterns/card-layout/Details.tsx#L36

Instead, it would be simpler and more powerful to implement grid as:

.cards {
  display: grid;
  gap: 1rem;
  grid-template-columns: repeat(4, 1fr);
}

Am I missing something?

I'll be happy to PR this if you agree.

Xaviju avatar Jun 01 '21 07:06 Xaviju

This issue affects also this pattern: https://csslayout.io/patterns/simple-grid/

Xaviju avatar Jun 01 '21 08:06 Xaviju

@Xaviju If it would be possible then can you assign me to this issue I want to resolve this would be my first contribution

pragyamishra56 avatar Oct 06 '23 02:10 pragyamishra56

Sorry @pragyamishra56 this is not my repo. This issue was a suggestion to refactor an element layout that has never been responded by the repo owner. You should contact @phuocng

Xaviju avatar Oct 06 '23 05:10 Xaviju

@Xaviju How to contact @phuocng to him If you have any good first issues, could you please let me know Sir? I'm new to open source and eager to make contributions.

pragyamishra56 avatar Oct 06 '23 05:10 pragyamishra56