zktop icon indicating copy to clipboard operation
zktop copied to clipboard

default to using the ZK server’s cfg

Open calestyo opened this issue 8 years ago • 3 comments

If a ZooKeeper server is installed on the system, zktop is likely expected to connected to the ZK enseble of that and not only to the local ZK server.

• Set a default path for a ZooKeeper server configuration file to "/etc/zookeeper/conf/zoo.cfg". This value should be adapted by distributions to their respective ZooKeeper server package’s default path. • Unless “--server” is explicitly given and if the ZooKeeper server configuration file exists (is a regular file or a symlink to it) at the default path, use the later for determining to which ZooKeeper servers to connect. • Updated the documentation for these changes. • Added a note that with Python2, zktop now requires pathlib to be installed.

Signed-off-by: Christoph Anton Mitterer [email protected]

calestyo avatar Aug 15 '17 23:08 calestyo

@phunt Hey... anything new on this?

calestyo avatar Dec 19 '21 23:12 calestyo

Thanks @calestyo - tbh though I think when I looked at it originally (granted it's been a while...) I thought that I wanted to optimize for local usage as the default. I also didn't think that /etc/... was universal. Python2 should be removed entirely at this point given it's EOL for a while now.

phunt avatar Dec 21 '21 01:12 phunt

Not sure what you mean... doesn't it make just sense to use the config if it's there and if not fall back to the current localhost usage?

calestyo avatar Dec 21 '21 02:12 calestyo