RotationLock icon indicating copy to clipboard operation
RotationLock copied to clipboard

Landscape Mode

Open eyedeekay opened this issue 11 years ago • 2 comments

I added landscape mode in my fork of the code. You switch between modes by tapping, first tap is Portrait Locked mode, second is Landscape Locked mode, third is Unlocked mode. I edited the strings in the English version but am not able to provide translations for all the data files. I didn't have a copy of API level seven installed, but if you just merge RotationLockActivity.java and the res/values*/strings.xml files I didn't make any changes that would break using API level 7.

eyedeekay avatar Nov 09 '14 05:11 eyedeekay

@cmotc So why do you think your PR does not get merged? I was looking for an open-source app that does what RotationLock does, and I was surprised to see in the description that "Can not lock landscape orientation, because Android system does not allow it.", since proprietary apps seemed to be able to do that.

mpl avatar Nov 22 '16 02:11 mpl

I don't know why it's not merged, except that @phuang hasn't been around for a while, and strictly speaking, at the time that was written, the landscape mode thing may have been true. There wasn't a straightforward, non-foolish way to lock rotation in landscape mode until API level 11, which I think was Android 3.0, which I've never actually seen used? So where for such a long time they were still selling like half Android 2.3 phones, half of people couldn't have used my version. Also, at the time I was teaching myself how to write Android apps, and if you look at some of the commits, I did mangle his configuration a bit to get it to build on my machine. Looking at this now, I'm going to go back through and do that properly this weekend.

That said, I have made my version available on F-Droid if you would like to use it or if you don't want to use F-Droid and you just want to download the APK and install it yourself, I also recommend you get it from them.

eyedeekay avatar Nov 22 '16 02:11 eyedeekay