phpstan-webmozart-assert icon indicating copy to clipboard operation
phpstan-webmozart-assert copied to clipboard

Support string assertions resulting in non-empty-string

Open herndlm opened this issue 3 years ago • 2 comments

Closes https://github.com/phpstan/phpstan-webmozart-assert/issues/129

Brings back what was reverted in https://github.com/phpstan/phpstan-webmozart-assert/pull/89 and steals ideas from https://github.com/phpstan/phpstan-webmozart-assert/pull/128

herndlm avatar Jul 14 '22 19:07 herndlm

I want to check if I can make it report if those functions are called more than once with the same args

herndlm avatar Jul 15 '22 04:07 herndlm

Now it works as I imagined :) I'm gonna add the same double-check-report adaption to phpstan-src with str_contains if possible.

herndlm avatar Jul 15 '22 14:07 herndlm

jfyi in case it was missed - I think this one should be good

herndlm avatar Aug 13 '22 08:08 herndlm

Really nice!

ondrejmirtes avatar Sep 21 '22 13:09 ondrejmirtes

Thank you.

ondrejmirtes avatar Sep 21 '22 13:09 ondrejmirtes