phpstan-src icon indicating copy to clipboard operation
phpstan-src copied to clipboard

implement MissingMagicSerializationMethodsRule

Open staabm opened this issue 3 years ago • 3 comments

closes https://github.com/phpstan/phpstan/issues/7482 refs https://github.com/phpstan/phpstan/issues/7953

staabm avatar Sep 08 '22 08:09 staabm

not sure how to fix the phpstan error on 7.2

Error: Call to method getMethods() on an unknown class PHPStan\BetterReflection\Reflection\Adapter\ReflectionEnum.
 ------ --------------------------------------------------------------------- 
  Line   src/Rules/Methods/MissingMagicSerializationMethodsRule.php           
 ------ --------------------------------------------------------------------- 
  51     Call to method getMethods() on an unknown class                      
         PHPStan\BetterReflection\Reflection\Adapter\ReflectionEnum.          
         💡 Learn more at https://phpstan.org/user-guide/discovering-symbols   
 ------ --------------------------------------------------------------------- 

staabm avatar Sep 08 '22 08:09 staabm

except the one remaining problem mentioned in https://github.com/phpstan/phpstan-src/pull/1711#issuecomment-1240398132 this should be good to go

staabm avatar Sep 22 '22 11:09 staabm

except the one remaining problem mentioned in https://github.com/phpstan/phpstan-src/pull/1711#issuecomment-1240398132 this should be good to go

inspired by https://github.com/phpstan/phpstan-src/commit/be1ce08748de9f13d9cc27ff6da39f0c173c92e8 I figured, I should also add this error to the ignore list. I did so with 8680735

staabm avatar Sep 29 '22 10:09 staabm

Thank you.

ondrejmirtes avatar Oct 16 '22 11:10 ondrejmirtes