phpstan-src icon indicating copy to clipboard operation
phpstan-src copied to clipboard
verified publisher icon phpstan

Implement @phpstan-allow-private-mutation

Open zonuexe opened this issue 3 years ago • 1 comments

resolve https://github.com/phpstan/phpstan/issues/7778, refs https://github.com/phpstan/phpstan-src/pull/1609

zonuexe avatar Aug 11 '22 16:08 zonuexe

ReadOnlyByPhpDocPropertyAssignRuleTest alone will pass with e2d9db8fc29efb52a847de6df704b7a540c0331e patch, but you probably need to rethink how ResolvedPhpDocBlock::$phpDocNode is initialized.

zonuexe avatar Aug 11 '22 16:08 zonuexe

@ondrejmirtes Could you please review this PR?

zonuexe avatar Sep 13 '22 10:09 zonuexe

Sorry, I accidentally submitted a re-review. Ignore it for once.

zonuexe avatar Sep 25 '22 07:09 zonuexe

I've updated the PR with the correct fix.

ondrejmirtes avatar Sep 27 '22 12:09 ondrejmirtes

Thank you.

ondrejmirtes avatar Sep 27 '22 12:09 ondrejmirtes