phpstan-src icon indicating copy to clipboard operation
phpstan-src copied to clipboard

Fixes #6938

Open ChrisBrenton opened this issue 3 years ago • 1 comments

Closes phpstan/phpstan#6938

Hello. This is my first PR to phpstan. It is quite a large codebase and I am still trying to understand it. As such, this fix may not be the best approach to take, so I am very open to feedback on how to better go about solving this.

ChrisBrenton avatar Aug 02 '22 20:08 ChrisBrenton

Hi, I appreciate the effort! But this is suspicious. I guess this doesn't address the root issue, because similar functions like is_string() etc. don't need this code in order to work properly.

ondrejmirtes avatar Aug 05 '22 20:08 ondrejmirtes

Hi, I'm cleaning up old and stale PRs. Please send a new PR if you're still interested, thanks.

ondrejmirtes avatar Oct 16 '22 10:10 ondrejmirtes