phpstan-src icon indicating copy to clipboard operation
phpstan-src copied to clipboard
verified publisher icon phpstan

Fix resolving mixed + array

Open staabm opened this issue 3 years ago • 1 comments

rebased version of https://github.com/phpstan/phpstan-src/pull/1445 reworked to use isSuperTypeOf checks (feedback from ondrey).

#1445 seemed abandoned therefore I figured I could push it over the finishing line

Fixes https://github.com/phpstan/phpstan/issues/7492

staabm avatar Aug 01 '22 17:08 staabm

//cc @rvanvelzen

staabm avatar Aug 02 '22 06:08 staabm

@herndlm after your recent changes on the mixed type I see new/no longer reported errors after rebase.

would be great if I could get your opinion on these.

staabm avatar Aug 25 '22 07:08 staabm

@herndlm after your recent changes on the mixed type I see new/no longer reported errors after rebase.

would be great if I could get your opinion on these.

I think I see failures related to https://github.com/phpstan/phpstan-src/pull/1641, so maybe left or right *never* types are incorrectly handled?

herndlm avatar Aug 25 '22 08:08 herndlm

good catch. fixed in ea57b6e

thank you.

staabm avatar Aug 25 '22 08:08 staabm

Thank you!

ondrejmirtes avatar Aug 29 '22 12:08 ondrejmirtes