phpstan-src icon indicating copy to clipboard operation
phpstan-src copied to clipboard

Improve in_array ConstantArrayType handling

Open herndlm opened this issue 3 years ago • 1 comments

well, another try of improving in_array, this time ConstantArrayType-specific only. It seems to be adding value, but I don't like that one conditional and that ConstantArrayType need this extra handling. I didn't find a way around both yet though.

herndlm avatar Jul 26 '22 10:07 herndlm

This is still bad, e.g. what about unions of constant arrays.. But at least no unexpected CI errors

herndlm avatar Jul 26 '22 19:07 herndlm

Hi, I'm cleaning up old and stale PRs. Please send a new PR if you're still interested, thanks.

We should probably revisit this later once we learn a bit more about the problem domain :)

ondrejmirtes avatar Oct 16 '22 10:10 ondrejmirtes