phpstan
Don't generalize template types
A little experiment to see what happens. Psalm doesn't generalize template types either, because a @var is easy enough to write.
a @var is easy enough to write
Yeah but the same argument can be used to keep the current behaviour :)
BTW Can you please tell me which items from https://github.com/phpstan/phpstan/issues/3853#issuecomment-1082351763 do you plan to work on? Once I finish the memory optimization I'm working on right now, the only thing before releasing 1.6.0 is the finished support for conditional return types, so I'd like to get that over the finish line too :) Thanks.
a @var is easy enough to write
Yeah but the same argument can be used to keep the current behaviour :)
Definitely. Just throwing this out there :)
BTW Can you please tell me which items from phpstan/phpstan#3853 (comment) do you plan to work on? Once I finish the memory optimization I'm working on right now, the only thing before releasing 1.6.0 is the finished support for conditional return types, so I'd like to get that over the finish line too :) Thanks.
Sure. I'm planning on working on these today:
- [ ] New rule - is the type in ConditionalTypeNode part of the function's @template type map?
- [ ] New rule - does the parameter in ConditionalTypeForParameterNode exist?
I'm not sure how soon I'll get to any of the rest. I do realize that that doesn't help much, but I'd rather not make false promises.
Yeah, this is totally fine, I can take over some of the work myself, just wanted to make sure we're synchronized (I'll let you know when I'm gonna work on some of the tasks).
Just want to let you know that I probably won't be able to work on the conditional types this week. I was planning on doing more but life is busy as well :)
I'm interested in not generalizing the types, but IMHO it needs to be paired with this suggestion https://github.com/phpstan/phpstan/issues/6732#issuecomment-1062029088 to be usable. The whole thread is worth reading, but here I especially refer to the Collection<unresolved> part.
Alright, I realized we can not-generalize types outside of GenericObjectType: https://github.com/phpstan/phpstan-src/pull/2818
But it's still a BC break so it's going to be bleeding edge-only for now.
Inside of GenericObjectType we're gonna need this logic https://github.com/phpstan/phpstan/issues/6732#issuecomment-1062029088
But anyway this is still going to fix a lot of issues.