grumphp icon indicating copy to clipboard operation
grumphp copied to clipboard

Add allow-list config option to securitychecker_enlightn

Open peterjaap opened this issue 3 years ago • 6 comments

Q A
Branch master for features and deprecations
Bug fix? no
New feature? yes
BC breaks? no
Deprecations? no
Documented? yes
Fixed tickets https://github.com/phpro/grumphp/discussions/1037

Add allow-list config option to be able to ignore given vulns, see https://github.com/enlightn/security-checker#allow-vulnerabilities

peterjaap avatar Nov 15 '22 09:11 peterjaap

Needs some work, I'll get back to this.

peterjaap avatar Nov 15 '22 09:11 peterjaap

@veewee done! :partying_face:

peterjaap avatar Nov 19 '22 16:11 peterjaap

@peterjaap It's a nice feature... Care to finish up this PR? :)

veewee avatar Sep 29 '23 08:09 veewee

@veewee sure, but I've asked you some questions in the comments

peterjaap avatar Sep 29 '23 11:09 peterjaap

@veewee sure, but I've asked you some questions in the comments

@peterjaap Is it possible you made those comments as part of a code review but did not submit those comments? I am not seeing any.

veewee avatar Sep 29 '23 11:09 veewee

@veewee woops, you're right :see_no_evil: Almost a year ago, lol.

peterjaap avatar Sep 29 '23 11:09 peterjaap