php-code-generator icon indicating copy to clipboard operation
php-code-generator copied to clipboard

Features adding suggestion

Open sidux opened this issue 6 years ago • 1 comments

Hi,

I have some ideas if you approve of i will create a PR for it :

  • handle types by adding a PhpType interface that will be implemented by PhpClass and PhpInterface classes to be able to automatically add use statements
  • PhpMethod and PhpParameter type will be list of types merged from typehint and docblock (if we set multiple types we will use only doc block)
  • PhpClass getInterfaces return collection of PhpInterface objects
  • Auto add use statement when adding an interface to PhpClass

What do you think of this ?

Cheers,

sidux avatar Nov 20 '19 21:11 sidux

Sorry for not responding earlier, next week will even be better:

handle types by adding a PhpType interface that will be implemented by PhpClass and PhpInterface classes to be able to automatically add use statements

I see what you are after. I like it, just do not like the name PhpType - something better and we can have it as an interface for interfaces and classes.

PhpMethod and PhpParameter type will be list of types merged from typehint and docblock (if we set multiple types we will use only doc block)

I unfortunately don't get that one - can you explain in more detail please? :)

PhpClass getInterfaces return collection of PhpInterface objects

They actually do. It's a Set from phootwork/collection.

Auto add use statement when adding an interface to PhpClass

Yup, pass in a PhpInterface and a use statement will be added :)

Thanks for your ideas. Let's clarify them and then see how we can implement them :)

gossi avatar Dec 08 '19 10:12 gossi