Charles Pick

Results 105 comments of Charles Pick

@scolacur this is a strange one, what command are you running with `flow-runtime-cli`?

@scolacur really strange then as flow-runtime doesn't really know about file locations. I wonder if this is related to webpack's caching

@olosegres did you try using `flow-runtime-cli` to extract those types?

@bradennapier pull requests accepted, I don't have time to work on this lib at the moment

It happens because flow-runtime cannot resolve that type, are there any type definitions for `AxiosPromise`? If so flow-runtime-cli should be picking them up

Need to figure out why `flow-runtime-cli` isn't picking it up, which version is coming from `flow-typed`? Presumably https://github.com/flowtype/flow-typed/tree/master/definitions/npm/axios_v0.16.x ? It will be a while before I have time to look...

We use a string ref (in this case) because at this stage we don't know whether `Map` is a concrete value or a type. I guess we could generate something...

> `babel-plugin-flow-runtime` is converting types to concrete values anyway; This is true most of the time, but not for *global* type definitions, for example if something is an `Iterable` we...

This will work for known builtins but not anything that's declared in a file in the `flow-typed` directory, e.g. if you use express it's relatively common to use `express$Request` without...

I quite like the idea but I also don't want to reinvent Flow, the *best* solution would be to make Flow's type information accessible at the AST level in babel,...