phpmyadmin
New website UI
By now it's usable, but not so great if anyone wants to see in a live environment. My plan is to finish, at least the first usable version at the end of the week,
Codecov Report
Merging #137 (63ffe13) into master (33e59a0) will decrease coverage by
0.28%. The diff coverage isn/a.
@@ Coverage Diff @@
## master #137 +/- ##
==========================================
- Coverage 63.28% 63.00% -0.29%
==========================================
Files 65 65
Lines 1419 1419
==========================================
- Hits 898 894 -4
- Misses 521 525 +4
![codecov[bot] avatar](https://avatars.githubusercontent.com/in/254?v=4 "Published by a pub.dev verified publisher"){kind=small}
Home is finished on desktop. I'm moving to internal pages to make them usable on the new UI (and do some rewrites when it's applicable) and then move to mobile.
There's no style for nav pills, paginations and tables yet.
Feel free to give me feedbacks :)
I have just a few fixes to do, but I think that it's easier to make this PR for a desktop version and, after merged, go to mobile.
Since the mobile is wrong in some places on the current UI (menu, code block, some tables) and no one opened an issue, I think that most people don't really see the website on mobile... ¯\(ツ)/¯
I still need to fix Books (inside Docs), Donate, and History layouts (they are working, but not with the best visual).
A "small" changelog before:
- Docs URLs to Django 1.7 are removed from the Django site. I found the readthedocs mirrors and changed when I found them.
- Changed the Download link on the header to move to the Download page since we don't have a link to that page. CTA button on page stills points to download directly.
- Try button points to the Try page, so the user can see all the warnings before starts. Inside the page, there's a button to Demo env.
- Added a Download button on Docs page for people who visit with mobile, since the Header CTA buttons will not appear on small resolutions.
- Removed bootstrap since I don't think that you use neither 30% of the package. I made custom css instead that matches your current use (and may match your future needs). I may write internal documentation for those styles later.
- Removed FontAwesome too, since all the icons now are SVG's.
- Move from
to element to match new specs (https://developer.mozilla.org/en-US/docs/Web/HTML/Element/content) - Made some styles specific so you don't need to read documentation all the time, doesn't break the style guide unintentionally neither use classes where is not needed. (you just can use the
.footer-linkclass inside the footer element. You can just use.btn-biginside.btnelement. You will never see afooter-linkon navbar without some strangeness -- easier to spot on future PR) - Moved components to a component folder to better differentiate component/include from templates files
- I made an alert component, just use
alertin conjunction with some alert definition (alert-info,alert-error,alert-success,alert-warning). You can see it on the Download popup. - Fixed the modal style
- Fixed the progress bar styles
- Add the Logo history text
- Removed unused (and fully deprecated) Google Code from 404 page
Problems that I faced on local env:
- Cannot run News and Security page, so I made changes directly on html and didn't test on live code itself, only in generated HTML (maaaaaybe because I'm using Windows?)
- We need an
ifon line 134 (index.html) to not show the year if it's the current. I don't know how to do this on Django. - I may have broken the Announcement list accordion on the Security page (Support > Security) (need to view on a more stable env)
- Download popup here just flashes, but I think that it's because I don't have anything to download. Needs a proper env to test.
- Some screenshots doesn't have data because I don't have that data on my local env. I don't know why.
On Mobile works, but it's pretty broken right now (gray block is the menu that I didn't put the icon yet, so made gray just to find the click area).
Very good work !
I will print this logo on a t-shirt ASAP when it is uploaded to the data repo :heart_eyes:
I think that we can proceed with review and fixes, then wait for the new brand to become available (I hope that the end of this week) to update it and merge.
We already finished the logo as a symbol itself, we're trying a few OSS typographies to match a better visual.
Conflicting files are because I changed the path and the elements inside, but the content is the same.
Edit: Can we deploy to a test environment with the actual server configs? My local has a lot of bugs (windows? hmmm -- yes, didn't install docker again :( )...
Doing a lot of nothing these months, I made a preview Dark Theme (that respects browser definitions!) for the website, but since it's heavily untested, I prefer to leave commented out. if you want to proceed with that in the future, it's already in the code :)
Default Logo
Symbol (when there's no space to use the default logo, like favicons)
There's another one to use in dark backgrounds, but is only the symbol with a circle behind it. We don't have the full logo for use in dark backgrounds yet, but I don't think that it's the main concern right now.
The typography used was Montserrat, but I'll make the update with all the infos in the Brand Guide that we'll be made availiable later.
I'll update that PR and the data repository with the new logos by the end of the day.
JFYI: I don't how do you handle the conflicts and merge strategies, but I don't have access to either.
To be honest, I always have problems with the rebase, :( I don't know if I want to proceed or prefer that you resolve this.... hahaha
To be honest, I always have problems with the rebase, :( I don't know if I want to proceed or prefer that you resolve this.... hahaha
We can rebase or merge locally with resolving conflicts, maybe another or 2 review would be okay so I can proceed with a merge. Maybe @ibennetch would be able to fix https://github.com/phpmyadmin/website/pull/137#discussion_r530316003 ? I do not charm pythons :snake: sorry ^^
First, Happy New Year! :)
Now comes the question: is something missing to proceed to merge/deploy @ibennetch @mauriciofauth?
Hi @AdrianoCahete, I rebased your pull request and I also fixed an issue with the template include paths.
I may have broken the Announcement list accordion on the Security page (Support > Security) (need to view on a more stable env)
Yes, it is broken.
Some screenshots doesn't have data because I don't have that data on my local env. I don't know why.
Maybe you forgot to load the test data:
./manage.py migrate
./manage.py loaddata pmaweb/fixtures/test_data.json
See: https://github.com/phpmyadmin/website#development
I think you should add a section on the home page for the Software Freedom Conservancy logo.
I may have broken the Announcement list accordion on the Security page (Support > Security) (need to view on a more stable env)
Yes, it is broken.
Some screenshots doesn't have data because I don't have that data on my local env. I don't know why.
Maybe you forgot to load the test data:
./manage.py migrate ./manage.py loaddata pmaweb/fixtures/test_data.jsonSee: https://github.com/phpmyadmin/website#development
I tried, but it cannot run on Windows (ModuleNotFoundError: No module named 'urllib2'). But, to be honest, I'm receiving an error now when I try to run the website on my machine (not happened before or I managed to fix it on my end).
I'm a little busy right now, but I'll try to fix that in the next weeks.
I think you should add a section on the home page for the Software Freedom Conservancy logo.
Right aligned on the same line/row as the Sponsors, maybe?
I tried, but it cannot run on Windows (ModuleNotFoundError: No module named 'urllib2'). But, to be honest, I'm receiving an error now when I try to run the website on my machine (not happened before or I managed to fix it on my end).
Could be a python3 issue instead you would probably need to use python2
I think you should add a section on the home page for the Software Freedom Conservancy logo.
Right aligned on the same line/row as the Sponsors, maybe?
I thought about a full width banner with the logo and some text.
Sorry for my disappearance. I had a completely broken computer (and a completely new one!) and two new jobs in the past few months...
I'll try to run the project again (and maybe make a PoC in another language too) as soon as possible!