sql-parser icon indicating copy to clipboard operation
sql-parser copied to clipboard

Push Statement::parse() down to SelectStatement

Open MauricioFauth opened this issue 1 year ago • 3 comments

This removes SelectStatement specific code from Statement::parse() method.

MauricioFauth avatar Jan 25 '24 19:01 MauricioFauth

Codecov Report

Attention: Patch coverage is 97.43590% with 2 lines in your changes are missing coverage. Please review.

Project coverage is 96.33%. Comparing base (48bd285) to head (99e20df). Report is 2 commits behind head on master.

:exclamation: Current head 99e20df differs from pull request most recent head 7f61f31

Please upload reports for the commit 7f61f31 to get more accurate results.

Files Patch % Lines
src/Statements/SelectStatement.php 97.36% 2 Missing :warning:
Additional details and impacted files
@@             Coverage Diff              @@
##             master     #546      +/-   ##
============================================
- Coverage     96.55%   96.33%   -0.22%     
- Complexity     2166     2174       +8     
============================================
  Files            87       86       -1     
  Lines          5025     5051      +26     
============================================
+ Hits           4852     4866      +14     
- Misses          173      185      +12     

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

codecov[bot] avatar Jan 25 '24 19:01 codecov[bot]

Is there anything we can do about all the PHPStan warnings?

kamil-tekiela avatar Jan 25 '24 19:01 kamil-tekiela

Can you rebase merge this ?

williamdes avatar May 09 '24 08:05 williamdes