phpmyadmin
ANSI mode not working, PHP 7
Hi, while investigating issue https://github.com/phpmyadmin/phpmyadmin/issues/15821 i came to conclusion, that sql-parser does not work correctly in my environment.
I'm using php from sury.org, currently 2:7.4+72+0~20200122.20+debian10~1.gbpcd96c7
Using MySQL server version 8.0.18 with ANSI_QUOTES mode (full list of modes at the end of this comment https://github.com/phpmyadmin/phpmyadmin/issues/15821#issuecomment-578572914 ), yours lint-query fails to parse double-quotes correctly and complains (both table name and field names are escaped by double-quotes in ANSI mode)
#1: A symbol name was expected! (near ""id"" at position 29)
#2: At least one column definition was expected. (near ""id"" at position 29)
#3: Unexpected beginning of statement. (near "11" at position 38)
#4: Unrecognized statement type. (near "NOT NULL" at position 42)
I tried to tweak using ContextMySql80000 and/or ANSI or ANSI_QUOTES modes, but the behavior did not change, with any of my tries.
Test data are also in mentioned comment, the string is taken directly from phpmyadmin result of SHOW CREATE TABLE query executed from configured datasource.
Once I change manually double-quotes to backticks, everything works correctly.
However I've tried tokenzier CLI utility, and the output is the same, for sql query with double-quotes and with backticks (except for Token containing raw value with backticks/doublequotes), Token values, types and flags are correctly the same.
Please let me know, if I can provide you with more debug info for you to test/fix this
Also please correct me if I'm wrong, but looking through your tests data, there is no input data in ANSI_QUOTES format, which means you so far supported only serialization but not deserialization ?
which means you so far supported only serialization but not deserialization ?
@devenbansod do you know ?
@williamdes @devenbansod I've created solution proposal in #294 , so you might close this issue, if we should continue discussing the problem in mentioned PR
I'm closing this ticket in favor of #294 so we don't fragment the discussion
@smarek did you see #124 and https://github.com/phpmyadmin/sql-parser/commit/f06862f070d81d4b13ad9022d3489300503850cc
@williamdes I did and as I said in https://github.com/phpmyadmin/sql-parser/issues/284#issuecomment-579635589 I tried, and tested, and yes, replacing escape character in ANSI mode when building query worked since 2017, but parsing query in ANSI mode apparently not