docker icon indicating copy to clipboard operation
docker copied to clipboard

Could you please implement the "AllowRoot" parameter?

Open yanhuixie opened this issue 7 years ago • 5 comments

Nice job! We have never mede a working phpmyadmin in such a convenient way. We hope to disallow root log on from web. I think everyone will agree that this is a good practice. So could you please implement the "AllowRoot" parameter in "docker/etc/phpmyadmin/config.inc.php"? I'm sure that would be great help. REF: https://docs.phpmyadmin.net/en/latest/config.html#cfg_Servers_AllowRoot

yanhuixie avatar Nov 22 '18 03:11 yanhuixie

The default value is true so I think what you ask is an enhancement, right ?

williamdes avatar Sep 30 '19 17:09 williamdes

You can override the configuration using volume mounts or with #262

williamdes avatar Dec 24 '19 11:12 williamdes

The default value is true so I think what you ask is an enhancement, right ?

Especially if the default it true I would very much want to override it with AllowRoot=false from the environment variables in my Docker Compose file.

I would also suggest setting the default to false for security reasons and let it be explicitly unsafe instead of other way around. It shouldn't be too hard to implement like here: https://github.com/phpmyadmin/docker/blob/f79c7073ab4f3abf9267735a3f69572ed8ae7628/config.inc.php#L54-L56.

I would like to see the same for AllowNoPassword=false. Default false, and overridable to true. Here: https://github.com/phpmyadmin/docker/blob/f79c7073ab4f3abf9267735a3f69572ed8ae7628/config.inc.php#L136

JaneX8 avatar Nov 14 '24 13:11 JaneX8

Let's go for re-opening this, I agree this is quite a pain

williamdes avatar Dec 21 '24 20:12 williamdes

Pull-requests are very welcome @JaneX8

williamdes avatar Dec 21 '24 20:12 williamdes