Onion
Onion copied to clipboard
Errors on tests
When you run Onion test you get, for example: Undefined property: tests\Onion\Dependency\DependencyResolverTest::$logger
Because some tests use $logger as a static variable but it is not. So we have two approaches:
- Use mocked instances of logger;
- Creating an instance of logger to each test;
For that, we can get the logger from Onion\Application::getInstance()->getLogger() for now. ;-)
Do you have any flow to pull requests? Because I really wanna contribute with you :-)
Nop, you simply run unit tests, if tests passes, the pull request should be fine. ;-)