arkitect icon indicating copy to clipboard operation
arkitect copied to clipboard

Parsing dependencies recursevily

Open AlessandroMinoccheri opened this issue 3 years ago • 1 comments

In this PR I changed how we parse files with their dependencies. If we find a dependency, now we check also inside it other dependencies recursively.

Now the collection of ClassDescription has the responsibility to check rules because we need to get all the dependencies of the class to be checked.

AlessandroMinoccheri avatar Feb 10 '22 04:02 AlessandroMinoccheri

Codecov Report

Merging #239 (537f3dc) into main (efc2ea8) will decrease coverage by 2.90%. The diff coverage is 81.32%.

Impacted file tree graph

@@             Coverage Diff              @@
##               main     #239      +/-   ##
============================================
- Coverage     92.99%   90.09%   -2.91%     
- Complexity      315      384      +69     
============================================
  Files            52       54       +2     
  Lines           814      999     +185     
============================================
+ Hits            757      900     +143     
- Misses           57       99      +42     
Impacted Files Coverage Δ
src/Analyzer/FileParser.php 75.26% <75.32%> (-9.92%) :arrow_down:
src/Analyzer/ClassDescriptionCollection.php 76.56% <76.56%> (ø)
src/Analyzer/FileVisitor.php 85.96% <77.77%> (-2.04%) :arrow_down:
src/Expression/ForClasses/NotExtend.php 82.35% <83.33%> (-3.37%) :arrow_down:
src/Analyzer/FileContentGetter.php 84.61% <84.61%> (ø)
src/CLI/Runner.php 94.28% <88.23%> (-1.37%) :arrow_down:
src/Expression/ForClasses/Extend.php 94.44% <92.85%> (+2.77%) :arrow_up:
src/Analyzer/ClassDescriptionBuilder.php 88.46% <100.00%> (ø)
src/Analyzer/FileParserFactory.php 100.00% <100.00%> (ø)
...ession/ForClasses/DependsOnlyOnTheseNamespaces.php 100.00% <100.00%> (ø)
... and 13 more

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update efc2ea8...537f3dc. Read the comment docs.

codecov-commenter avatar Feb 12 '22 09:02 codecov-commenter

La chiudiamo questa? È aperta da tempo immemore... :D

pfazzi avatar Sep 02 '22 09:09 pfazzi