Publish Windows binaries to Release
Added four steps in windows build and test:
- Extract version
- Define Module Env
- Upload artifacts
- Publish Binaries to Release
Here you can see what a Release would look like:
https://github.com/alphp/pecl-system-dio/releases/tag/0.3.0
Well, usually the releases are published on PECL, and there are DLLs available (again), so this just might be confusing to users.
I don't see any problem with publishing the binaries here as well. You can always link to the official repository and in case of disaster there is GitHub as an alternative. I also think it is a way to provide a standardized build system.
I also think it is a way to provide a standardized build system.
A standardized build system for PHP and all extensions is what https://github.com/php/php-windows-builder is all about: use the same version of toolset (compiler, linker, etc.), Windows SDK, and dependencies (which ideally should have also been built with these versions), and what not, to build PHP core and all public extensions. And, if need be, be able to quickly rebuilt all that stuff.
In my opinion, it is fine to upload Windows build artifacts for pushes and pull requests, so users can test whether a certain commit actually fixes their problems (or whether a certain new feature actually meets their expectation), but DLLs used in production should better come from a central place.
I didn't know about the standardized action for building php and extensions. I'll try it before updating this PR with it.
As far as I can see, there is still a long way to go in terms of standardizing the construction method. At least in Windows environments:
- extension-matrix does not work
- Fails to build and test
At least in Windows environments:
- extension-matrix does not work
- Fails to build and test
Please consider to file a ticket at https://github.com/php/php-windows-builder.