pecl-search_engine-solr icon indicating copy to clipboard operation
pecl-search_engine-solr copied to clipboard

Add a composer.json to enable support for PIE

Open bix0r opened this issue 1 year ago • 3 comments

See: https://github.com/php/pie/blob/main/docs/extension-maintainers.md

bix0r avatar Dec 04 '24 14:12 bix0r

Hi @bix0r, good to see u're back :)

Let's please work on >= PHP 8.1

The rest are EOLed, we shouldn't really spend any efforts there, either we fully support or not fully support. Let's focus our efforts towards the future, I'm happy to have a call about this if needed.

omars44 avatar Dec 08 '24 04:12 omars44

I am going to move this PR to draft because there is some discussion on the vendor name for extensions living in github.com/php. See Composer issue.

bix0r avatar Dec 30 '24 14:12 bix0r

I am going to move this PR to draft because there is some discussion on the vendor name for extensions living in github.com/php. See Composer issue.

sure

omars44 avatar Jan 13 '25 08:01 omars44

@remicollet I wonder if we should add this package to the pecl/ namespace?

I see that you have been adding some existing packages to the pecl/ namespace, and according to https://externals.io/message/128536#128614 and a comment on the linked composer issue above, it seems like that would be the way to go.

Otherwise I think that I will just go with php-solr/solr. Other option would be apache/php-solr that has been proposed to me in discussions with some core devs, but I am not sure I like that one.

bix0r avatar Oct 11 '25 11:10 bix0r

@remicollet I wonder if we should add this package to the pecl/ namespace?

Your choice ;) In this case, you need someone who already own 1 pecl package to add it in this namespace, and then give you the ownership. (I can do it).

I think "pecl" vendor is useful for extensions inherited from the community with no real author. Also for project in the php github organization (moved from git.php.net)

"apache" may be interesting for all ASF hosted projects, but if used by this extension it will be locked (like the pecl one) so probably only if really managed by the ASF.

I also think "php" or "pie" in the "project" name doesn't make sense (everything is for php on packagist).

remicollet avatar Oct 12 '25 05:10 remicollet

Thank you for your input @remicollet. I really like your reasoning :)

I think "pecl" vendor is useful for extensions inherited from the community with no real author. Also for project in the php github organization (moved from git.php.net)

Since this package is not heading for major development and is in the php GH organisation, I think pecl is the best suited vendor. If we ever want to do some major refactoring or changes we could then look into moving it to its own organisation and then change the vendor.

@omars44 What do you think?

Your choice ;) In this case, you need someone who already own 1 pecl package to add it in this namespace, and then give you the ownership. (I can do it).

I will ping you if we decide to use pecl. Thank you.

bix0r avatar Oct 12 '25 08:10 bix0r

@remicollet I still think that pecl/ vendor is the best fit this package. So, unless you have any objections, I would appreciate it if you could add it to that namespace.

bix0r avatar Nov 20 '25 07:11 bix0r

@remicollet I still think that pecl/ vendor is the best fit this package. So, unless you have any objections, I would appreciate it if you could add it to that namespace.

I will add it, what is your packagist name so I can give it to you ?

remicollet avatar Nov 20 '25 08:11 remicollet

I will add it, what is your packagist name so I can give it to you ?

@remicollet it is: biggi-stefna

bix0r avatar Nov 20 '25 08:11 bix0r

This PR need to be merged first, cannot be added in packagist without composer.json

remicollet avatar Nov 20 '25 09:11 remicollet

biggi-stefna

You are now the owner of https://packagist.org/packages/pecl/solr

remicollet avatar Nov 20 '25 09:11 remicollet

Thank you @remicollet :+1:

bix0r avatar Nov 20 '25 10:11 bix0r